Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VCR tests using GA provider for GA-only PRs #9148

Closed
melinath opened this issue May 14, 2021 · 4 comments
Closed

Run VCR tests using GA provider for GA-only PRs #9148

melinath opened this issue May 14, 2021 · 4 comments
Labels
magician Issues and features related to our bespoke CI size/l technical-debt
Milestone

Comments

@melinath
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment or link the pull request to this issue.

Some PRs (like making something GA) only modify the GA provider. However, we currently only run tests on the beta provider. This can end up introducing bugs into the GA provider that would have been caught by VCR tests (if they had been run). It would be great if we could detect this case (i.e. changes to GA provider go code but not to beta provider go code) and run VCR tests for the GA provider instead of beta.

This is somewhat related to: #9147, in a way.

@rileykarson
Copy link
Collaborator

Notes: Figuring out a GA-only PR is difficult. We could consider a rule like "if go files are altered in ga and not beta, run at ga".

@rileykarson rileykarson added this to the Goals milestone May 17, 2021
@rileykarson rileykarson changed the title Run VCR tests in TeamCity using GA provider for GA-only PRs Run VCR tests using GA provider for GA-only PRs May 15, 2023
@melinath
Copy link
Collaborator Author

melinath commented Jan 2, 2024

We may want to run GA VCR tests on all PRs, which would make a duplicate of #13170

@rileykarson rileykarson added the magician Issues and features related to our bespoke CI label Mar 28, 2024
@melinath
Copy link
Collaborator Author

melinath commented May 10, 2024

We should just run GA VCR on all PRs that modify the GA provider.

@melinath melinath closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
magician Issues and features related to our bespoke CI size/l technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants