Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example description value of "test resource." in gke_hub_membership.html.markdown causes problems for membership resource #9401

Closed
linde opened this issue Jun 19, 2021 · 3 comments
Assignees
Labels

Comments

@linde
Copy link

linde commented Jun 19, 2021

The value makes it hard to use the cluster in the Anthos or GKE UI to configure ACM or even delete the membership later.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_gke_hub_membership

Terraform Configuration Files

## content from the example in the markdown file

resource "google_gke_hub_membership" "membership" {
  membership_id = "basic"
  endpoint {
    gke_cluster {
      resource_link = "//container.googleapis.com/${google_container_cluster.primary.id}"
    }
  }
  description = "test resource."   ### THIS IS PROBLEMATIC
  provider = google-beta
}

Debug Output

It actually "works" ok, you just cant use the resulting cluster for ACM or similar.

Expected Behavior

Just change to have a name that can be part of a resource and make docs to this effect and/or have validation, ideally.

Actual Behavior

Steps to Reproduce

follow the instructions, then try to configure a feature like ACM in the UI.

Important Factoids

References

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/gke_hub_membership

  • #0000
@linde linde added the bug label Jun 19, 2021
@edwardmedia edwardmedia self-assigned this Jun 19, 2021
@edwardmedia
Copy link
Contributor

edwardmedia commented Jun 20, 2021

@linde I am not clear what is wrong. After running below plan, I can verify the cluster has been registered by executing gcloud beta container hub memberships describe basic Can you provide the details specifying the problem?

resource "google_gke_hub_membership" "membership" {
  membership_id = "basic"
  endpoint {
    gke_cluster {
      resource_link = "//container.googleapis.com/${google_container_cluster.primary.id}"
    }
  }
  description = "test resource."
  provider = google-beta
}

@linde
Copy link
Author

linde commented Jun 21, 2021

hey, thanks for the follow-up! the problem might be on the google cloud console side, that a cluster with spaces or . in the description field causes problems with other hub feature setup. i think it is ok to reolve this item and we can follow-up interally.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants