Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a cloudbuild trigger from enterprise self hosted github #9956

Assignees
Labels
enhancement new-resource size/m tpgtools Issues related to the tpgtools generator
Milestone

Comments

@chitha20
Copy link

chitha20 commented Sep 1, 2021

Affected Resource(s)

  • google_cloudbuild_trigger

Current Problem :

Hi with the recent GA'ed of cloudbuild private github enterprise feature as mentioned here ,

we would like to leverage terraform automation in configuring the trigger for cloudbuild job from self hosted github. Current provider doc here

Right now the below terraform snippet tried to create a trigger from github which expects like this :

github.com/my-org/my-repo

And it fails for our case as we want to have capability to change the github.com towards self hosted github url.

resource "google_cloudbuild_trigger" "my-resources" {
  github {
    name  = "my-repo
    owner = "my-org"

    push {
      branch       = "^master$"
      invert_regex = false
    }
  }

  filename = "cloudbuild.yaml"
} 

Expected outcome :

We should have ability to configure the self hosted github_url in google_cloudbuild_trigger github section of the provider.

Let us know if there is a support for it already or if thats upcoming.

@rileykarson rileykarson self-assigned this Sep 13, 2021
@rileykarson
Copy link
Collaborator

I think this is a matter of adding both a resource for https://cloud.google.com/build/docs/api/reference/rest/v1/projects.githubEnterpriseConfigs#GitHubEnterpriseConfig and the enterpriseConfigResourceName field to trigger. The API guide is confusing, and talks about creating JSON files and pushing them using curl rather than using a language client.

@rileykarson rileykarson removed their assignment Sep 27, 2021
@rileykarson rileykarson added new-resource size/m tpgtools Issues related to the tpgtools generator labels Sep 27, 2021
@rileykarson rileykarson added this to the Goals milestone Sep 27, 2021
@NaurisSadovskis
Copy link

hey folks, any update on this?

@nickozilla
Copy link

Hi is anyone working on this?

@itsavvy-ankur
Copy link

Hi, I have recently stumbled on this as well. Just wondering if this is being worked upon or any workarounds exist for creating the trigger for GitHub enterprise repositories?

@sebxgd
Copy link

sebxgd commented Sep 2, 2022

I have same issue

@ramiresdallago
Copy link

ramiresdallago commented Sep 2, 2022

Hi, same issue here! Any news?

@prateek2408
Copy link
Contributor

Working on it.

@kuba-vodafone
Copy link

anyone knows when this change will be included in the release?

@rileykarson
Copy link
Collaborator

rileykarson commented Feb 16, 2023

Likely next Monday's Tuesday's release (delayed due to a holiday)

@kuba-vodafone
Copy link

hello,

do you know when today's release is expected?

@rileykarson
Copy link
Collaborator

Hmm- didn't look like it happened. I'll follow up w/ the release owner tomorrow (we're past their core hours right now).

@parmus
Copy link

parmus commented Feb 24, 2023

We are also eagerly awaiting this next release.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.