Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress diff on any email addresses without a type, as those are computed #154

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Sep 17, 2021

Fixes #150

Workspace will return a list of email addresses (either defined user aliases or ones that are computed, such as the primary email, an associated test email and emails from other managed domains). In the case of computed emails, they seem to not have a type (this is an assumption based on what we've seen). So instead of hardcoding just the primary email and the associated test email, we'll ignore any emails that don't have a type set. This is possible because type is required in our configuration file.

@ari-becker
Copy link
Contributor

Looks good to me 👍

Thank you!

@megan07 megan07 merged commit aa93b0e into main Sep 20, 2021
@megan07 megan07 deleted the megan_150 branch September 20, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

googleworkspace_user has a permadiff on default emails fields
3 participants