add support for service account access_token #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
approved these changes
Oct 5, 2021
gabor-farkas
reviewed
Oct 6, 2021
| creds := googleoauth.Credentials{ | ||
| TokenSource: oauth2.StaticTokenSource(token), | ||
| } | ||
| diags = c.SetupClient(ctx, &creds) |
There was a problem hiding this comment.
Hi, sorry for adding this late, but isn't a return statement missing here? This way, if there are no impersonated user specified, it will fall back to ADC at line 109, so the access token will be ignored finally.
There was a problem hiding this comment.
Oh good catch! I forgot I had that else down there. Thanks! I'll fix that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Not sure what all I can do in
infra.tfto prepare for this. I created a new service account with what I'm guessing is all the permissions it needs? But I think I'll need to set up DWD for it to work properly, so the tests may fail at first until I do that.Thanks to @gabor-farkas for all the help with this!!