Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make members optional on googleworkspace_group_members #193

Merged
merged 2 commits into from
Oct 27, 2021
Merged

make members optional on googleworkspace_group_members #193

merged 2 commits into from
Oct 27, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Oct 26, 2021

Fixes #191 so that group_members can remove members from a group.

@megan07 megan07 requested a review from appilon October 26, 2021 14:22
appilon
appilon requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove MinItems I think actually

@megan07
Copy link
Contributor Author

megan07 commented Oct 26, 2021

Interesting! It worked? But you're right - also, I should add a test :) Will do, thanks!

@megan07 megan07 requested a review from appilon October 26, 2021 15:18
@megan07 megan07 merged commit 08e36f0 into main Oct 27, 2021
@megan07 megan07 deleted the megan_191 branch October 27, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

googleworkspace_group_members can not remove all members from group
2 participants
@megan07 @appilon