add schema resource and data source #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
approved these changes
Apr 9, 2021
| } | ||
|
|
||
| schemasService, diags := GetSchemasService(directoryService) | ||
| if len(diags) > 0 { |
There was a problem hiding this comment.
Suggested change
| if len(diags) > 0 { | |
| if diags.HasError() { |
|
Just 1 minor thing |
|
As for the naming thing, I would lean towards UserSchema to avoid confusion with the Terraform schema 🤷♂️ |
megan07
force-pushed
the
megan_add_user_schema
branch
from
1a1fa20
to
6ff29cb
Compare
|
Just going to note that I think I'll keep it Schema for now in case it ends up being used with resources other than User. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema resource and data source.
Opinion question: should we call this
UserSchemaor leave it asSchema? The REST resource is justschemas, and I'd like to stay consistent with that. However, I think the only place this is used is withUsers, the Oauth scope isuserschema, and the community provider calls itgsuite_user_schema, so I could be swayed the other way.