Add org unit resource and datasource #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
approved these changes
May 26, 2021
| } | ||
|
|
||
| func dataSourceOrgUnitRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | ||
| if d.Get("org_unit_id") != "" { |
There was a problem hiding this comment.
Is it normal to have a data source that is essentially looked up by its ID?
There was a problem hiding this comment.
oh, you know what, let me take another look at this, i might have messed something up when i was testing it out. i think we can maybe look it up by org_unit_path, but I don't think we can look it up by name (although, org_unit_path is essentially <parent_org_unit_path>/<name> which would definitely make more sense.
appilon
approved these changes
May 26, 2021
appilon
approved these changes
May 26, 2021
megan07
added a commit
that referenced
this pull request
Jun 10, 2021
* add org unit resource and data source * remove datasource ability to get by orgunit path * adding docs * add ability go get org unit datasource with org_unit_path * add new docs with org_unit_path change
megan07
added a commit
that referenced
this pull request
Jun 10, 2021
* Add org unit resource and datasource (#63) * add org unit resource and data source * remove datasource ability to get by orgunit path * adding docs * add ability go get org unit datasource with org_unit_path * add new docs with org_unit_path change * Implement RoleAssignment Resource and Role datasource/resource (#66) * Implement role_assignment resource and role datasource * Implement Role resource * update changelogs, merge in main Co-authored-by: appilon <apilon@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Added org unit resource and datasource.