Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starter_small HCP Vault cluster tier #178

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Conversation

jfreda
Copy link
Member

@jfreda jfreda commented Aug 3, 2021

🛠️ Description

This adds support for the newly launched starter_small HCP Vault cluster tier. The HCP SDK was bumped to support this change.

🚢 Release Note

Release note for CHANGELOG:

* resource/hcp_vault_cluster: add `starter_small` cluster tier

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccVaultCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccVaultCluster -timeout 120m
?   	github.com/hashicorp/terraform-provider-hcp/internal/clients	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/consul	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/input	(cached) [no tests to run]
=== RUN   TestAccVaultCluster
--- PASS: TestAccVaultCluster (787.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	787.583s

@jfreda jfreda requested review from bcmdarroch and a team August 3, 2021 21:16
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jfreda jfreda merged commit 0645478 into main Aug 3, 2021
@jfreda jfreda deleted the jfreda/add-vault-starter-tier branch August 3, 2021 22:42
@bcmdarroch bcmdarroch mentioned this pull request Aug 3, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants