Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to release metadata, fix issue with test suite #1380

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

danielskowronski
Copy link
Contributor

  1. Add new computed fields to helm_release.metadata:
  2. Fix issue with tests that are using exec.Command to call helm CLI directly - they were expecting kubeconfig to be at $KUBECONFIG, which may not be the same as $KUBE_CONFIG_PATH. The latter is explicitly expected by test suite for Terraform part.

Description

Exposes more metadata about Helm release to extend the possibilities of other resources to act upon release changes. Additionally, provide primitive output from Helm deployment (rendered templates/NOTES.txt if available), which can be used with some bootstrap process.

In other words - adding missing data exposed by Helm.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

- add new attributes to helm_release.metadata: last_deployed, first_deployed, notes
- fix uses of helm CLI in tests: explictly use $KUBE_CONFIG_PATH

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@danielskowronski danielskowronski requested a review from a team as a code owner June 4, 2024 20:36
Copy link

hashicorp-cla-app bot commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/L label Jun 4, 2024
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall just need a few things changed to get it merged!

  • Could you rebase to fix the conflicts in the go.mod/go.sum files
  • Please add a file in .changelog/PRnumber.txt that details the change, you can see the most recent one as an example

@appilon
Copy link
Contributor

appilon commented Jun 11, 2024

Since this PR was so well done I'm going to take the liberty of getting the PR unblocked.

danielskowronski and others added 3 commits June 11, 2024 12:50
- last_deployed to implement hashicorp#1374
- first_deployed and notes to extend functionality further
tests that are using exec.Command to call helm CLI directly were expecting kubeconfig to be at KUBECONFIG, which may not be the same as KUBE_CONFIG_PATH
@appilon appilon merged commit 50ebe21 into hashicorp:main Jun 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants