Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for all resources before declaring successful completion #44

Closed
thedrow opened this issue Feb 6, 2018 · 2 comments
Closed

Wait for all resources before declaring successful completion #44

thedrow opened this issue Feb 6, 2018 · 2 comments

Comments

@thedrow
Copy link

thedrow commented Feb 6, 2018

When I deploy to production I usually use helm install <myrelease> --wait --timeout <reasonable timeout for deployment>.
This provider does not provide those options as of yet.
I think that providing those options will improve UX.

@sagikazarmark
Copy link

sagikazarmark commented Feb 13, 2018

There is a timeout option: https://github.com/mcuadros/terraform-provider-helm/blob/master/helm/resource_release.go#L107

Also, wait looks like to be hard coded with true value: https://github.com/mcuadros/terraform-provider-helm/blob/master/helm/resource_release.go#L267

@mcuadros
Copy link
Collaborator

Exactly the wait, isn't optional because Terraform should always wait until everything is setup and running.
As documented (https://github.com/mcuadros/terraform-provider-helm/blob/master/docs/release.md), the timeout option is supported.

Thanks @sagikazarmark

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants