Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): add pass_credentials option #841

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

toomai
Copy link
Contributor

@toomai toomai commented Mar 23, 2022

Description

This PR adds supports for the --pass-credentials option of the Helm client. This is useful when charts are located in a different location than where the index.yaml is. Some registries also rewrite the chart to include the port in the URL section. This prevented Helm from being able to download the Chart.

Acceptance tests

I did not see any tests on attributes like repository_username so I did not try to add some as this is the same type of attribute

Release Note

Release note for CHANGELOG:

Added `pass_credentials` attributes to the `helm_release` resource. Defaults to `false`

References

#847
https://helm.sh/docs/helm/helm_install/#options See --pass-credentials options.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 23, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @toomai ❤️

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants