Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded response code of 200 #41

Closed
akblackwel opened this issue May 5, 2020 · 2 comments · Fixed by #142
Closed

Hard coded response code of 200 #41

akblackwel opened this issue May 5, 2020 · 2 comments · Fixed by #142
Assignees
Milestone

Comments

@akblackwel
Copy link

I'm not really having an issue per say with this provider, but I would like to inquire into why the response codes on this provider are hard coded to 200.

if resp.StatusCode != 200

Why not the range of 200? At a min

200 | OK | [RFC7231, Section 6.3.1]
201 | Created | [RFC7231, Section 6.3.2]
202 | Accepted | [RFC7231, Section 6.3.3]

Thanks

@theipster
Copy link

In fact, the semantics of the response's HTTP status code (which codes are considered "good" or "bad") should actually be none of this http data resource's concern at all.

As a user, you make a HTTP request, then you receive a HTTP response. What's contained in that response (e.g. status code) should be the user's concern.

I dropped a comment in #114 (comment), WDYT?

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants