Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waiter crash when conditions are not present #2008

Merged
merged 3 commits into from Feb 20, 2023
Merged

Fix waiter crash when conditions are not present #2008

merged 3 commits into from Feb 20, 2023

Conversation

jrhouston
Copy link
Contributor

Description

This PR fixes a panic which occurs when the waiter tries to wait on conditions that are not present in the resource.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner February 17, 2023 03:59
@alexsomesan
Copy link
Member

Looks like the actual tf config file for the test might be missing:

https://github.com/hashicorp/terraform-provider-kubernetes/actions/runs/4200565768/jobs/7286707073#step:6:108

@github-actions github-actions bot added size/M and removed size/S labels Feb 17, 2023
@jrhouston jrhouston merged commit 7db1b34 into main Feb 20, 2023
@jrhouston jrhouston deleted the fix-waiter-crash-conditions branch February 20, 2023 17:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrhouston @alexsomesan @arybolovlev