Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual type of input value in morpher diagnostic. #2054

Merged
merged 2 commits into from Mar 21, 2023

Conversation

alexsomesan
Copy link
Member

@alexsomesan alexsomesan commented Mar 21, 2023

Description

Fixes a panic when constructing the diagnostic message if the moprher fails to find a valid converstion strategy between attribute type supplied by user config and the type dictated by the schema.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

`resource/kubernetes_manifest`: Fix a panic when constructing the diagnostic message about incompatible attribute types

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan requested a review from a team as a code owner March 21, 2023 14:57
@alexsomesan alexsomesan merged commit 4572e1b into main Mar 21, 2023
29 checks passed
@alexsomesan alexsomesan deleted the fix-morph-diag-panic branch March 21, 2023 17:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants