Add ["f:metadata"] check in kubernetes_labels to prevent crash with kubernetes_node_taints
#2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBBmau
changed the title
kubernetes_labels to prevent crash with kubernetes_node_taints["ff:metadata"] in kubernetes_labels to prevent crash with kubernetes_node_taints
BBBmau
changed the title
["ff:metadata"] in kubernetes_labels to prevent crash with kubernetes_node_taints["ff:metadata"] check in kubernetes_labels to prevent crash with kubernetes_node_taints
jrhouston
approved these changes
Aug 28, 2023
jrhouston
changed the title
["ff:metadata"] check in kubernetes_labels to prevent crash with kubernetes_node_taints["f:metadata"] check in kubernetes_labels to prevent crash with kubernetes_node_taints
jrhouston
reviewed
Aug 28, 2023
Co-authored-by: John Houston <jrhouston@users.noreply.github.com>
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
Nov 29, 2023
<Actions>
<action
id="bcd9b70d7c1eb1e07eb5ad8a958f18dc1bbd81461ee1a2604adeea46e3148a47">
<h3>Bump Terraform `kubernetes` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/kubernetes" updated from "2.23.0" to
"2.24.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>2.24.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v2.24.0
ENHANCEMENTS:

`kubernetes/schema_affinity_spec.go`:
Add `match_fields` to nodeAffinity
[[GH-2296](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2296)]
`kubernetes/schema_pod_spec.go`:
Add `os` to podSpecFields
[[GH-2290](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2290)]
`resource/kubernetes_config_map_v1_data`:
improve error handling while validating the existence of the target
ConfigMap.
[[GH-2230](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2230)]

BUG
FIXES:

* `resource/kubernetes_labels`: Add
["f:metadata"] check in kubernetes_labels to prevent crash with
kubernetes_node_taints
[[GH-2246](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2246)]

DOCS:

*
Add example module for configuring OIDC authentication on EKS
[[GH-2287](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2287)]
*
Add example module for configuring OIDC authentication on GKE
[[GH-2319](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2319)]

NOTES:

*
Bump Go version from 1.20 to 1.21.
[[GH-2337](https://github.com/hashicorp/terraform-provider-kubernetes/issues/2337)]
*
Bump Kubernetes dependencies from x.25.11 to
x.27.8.


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/905/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2023
This PR addresses the panic caused by the reference issue.
A second PR will be made which addresses the logic issues that appears from the panic solution.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note