Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources and data sources for CSI volumes and plugins #123

Merged
merged 14 commits into from
Jul 9, 2020
Merged

resources and data sources for CSI volumes and plugins #123

merged 14 commits into from
Jul 9, 2020

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Jul 8, 2020 •
edited

new resource for registering Nomad CSI Volumes
in addition, there are data sources for querying CSI plugins and volumes
some of these are very useful when orchestrating the installation of CSI plugins and controllers, as this is a dependency that must be satisfied before volumes can be registered

closes #102

@cgbaker cgbaker requested a review from lgfa29 July 8, 2020 20:50
lgfa29
lgfa29 previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes in the doc pages but it looks good.

It also seems to be missing entries in the side menu (website/nomad.erb)

nomad/data_source_volumes.go Show resolved Hide resolved
nomad/resource_volume.go Outdated Show resolved Hide resolved
website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/d/plugins.html.markdown Outdated Show resolved Hide resolved
nomad/provider.go Show resolved Hide resolved
website/docs/d/plugin.html.markdown Outdated Show resolved Hide resolved
@cgbaker cgbaker added this to the 1.4.8 milestone Jul 9, 2020
@cgbaker @lgfa29
Update website/docs/d/plugin.html.markdown
1e2c285 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
cgbaker and others added 7 commits July 8, 2020 19:57
@cgbaker @lgfa29
Update website/docs/d/plugins.html.markdown
c6c89fb 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@cgbaker @lgfa29
Update website/docs/r/volume.html.markdown
0b37a08 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@cgbaker @lgfa29
Update website/docs/r/volume.html.markdown
8fc22fc 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@cgbaker @lgfa29
Update website/docs/r/volume.html.markdown
3aeffbc 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@cgbaker @lgfa29
Update website/docs/r/volume.html.markdown
371478f 
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@cgbaker
added sensitive to nomad_volume.secrets
b08d308
@cgbaker
added new doc pages to sidebar
3a917e7
cgbaker
cgbaker commented Jul 9, 2020
View reviewed changes
website/nomad.erb Outdated Show resolved Hide resolved
@cgbaker cgbaker merged commit 2585591 into master Jul 9, 2020
@lgfa29 lgfa29 deleted the f-102-volume-resource branch August 13, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfa29 lgfa29 lgfa29 left review comments

@jrasell jrasell jrasell approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
1.4.8
Development

Successfully merging this pull request may close these issues.

Enhancement: Support for Nomad Volumes
3 participants
@cgbaker @lgfa29 @jrasell