Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nomad dependency to v0.12.2 #140

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Update Nomad dependency to v0.12.2 #140

merged 5 commits into from
Aug 13, 2020

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 12, 2020

Fixes #139

@lgfa29 lgfa29 requested review from cgbaker and jrasell August 12, 2020 22:38
@ghost ghost added the size/L label Aug 12, 2020
cgbaker
cgbaker previously approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mobile, but I didn't see a change to update the test suite to 0.12.2 binaries?

@lgfa29
Copy link
Contributor Author

lgfa29 commented Aug 12, 2020

I'm mobile, but I didn't see a change to update the test suite to 0.12.2 binaries?

Ah good catch. I also added a CHANGELOG entry.

cgbaker
cgbaker approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lgfa29 lgfa29 merged commit 2d94d84 into master Aug 13, 2020
@lgfa29 lgfa29 deleted the deps/nomad-0-12-2 branch August 13, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

@jrasell jrasell Awaiting requested review from jrasell

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for service check failures_before_critical
2 participants
@lgfa29 @cgbaker