Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing to 1.0.4, testing changes #206

Merged
merged 6 commits into from
Apr 1, 2021
Merged

parsing to 1.0.4, testing changes #206

merged 6 commits into from
Apr 1, 2021

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Mar 17, 2021

  • set nomad parsing to 1.0.4 (was accidentally set to HEAD by previous PR)
  • added tests for 1.0.4 features (terminating connect gateways)
  • some general testing cleanup

Comment on lines +62 to +81
func testEntFeatures(t *testing.T, requiredFeatures ...string) {
testCheckEnt(t)
client := testProvider.Meta().(ProviderConfig).client
resp, _, err := client.Operator().LicenseGet(nil)
if err != nil {
t.Fatal(err)
}
licensedFeatures := map[string]bool{}
if resp != nil && resp.License != nil {
for _, f := range resp.License.Features {
licensedFeatures[f] = true
}
}
for _, f := range requiredFeatures {
if !licensedFeatures[f] {
t.Skip(fmt.Sprintf("license doesn't include required feature %q", f))
}
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

lgfa29
lgfa29 previously approved these changes Mar 18, 2021
@cgbaker cgbaker added this to the 1.4.14 milestone Apr 1, 2021
@cgbaker cgbaker merged commit a448b06 into main Apr 1, 2021
cgbaker added a commit to Mongey/terraform-provider-nomad that referenced this pull request Apr 1, 2021
cgbaker added a commit to Mongey/terraform-provider-nomad that referenced this pull request Apr 1, 2021
cgbaker added a commit that referenced this pull request Apr 1, 2021
@jrasell jrasell deleted the f-api-to-104 branch April 20, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants