Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.17, Nomad 1.3.1, and add support to volume topologies. #270

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jun 7, 2022

Update Nomad to 1.3.1, Go to 1.17, and add support for volume topologies.

It also updates the test setup to run a CSI plugin to allow testing the nomad_external_volume (create volume). I haven't been able to figure out a good way to test nomad_volume (register volume).

These started as separate work streams but got so entangled that it was hard to keep the split. The commits are fairly split in the different items.

Closes #268

@lgfa29 lgfa29 force-pushed the f-volume-topologies branch 6 times, most recently from 2ea327c to 2120c55 Compare June 7, 2022 22:33
Use the new `nomad operator api` command instead of `httpie` and exit if
the ACL boostrap fails. Previously the non-zero return code would be
consumed by the pipe to `jq`.
@lgfa29 lgfa29 force-pushed the f-volume-topologies branch 5 times, most recently from e2500ec to a5fdff7 Compare June 8, 2022 15:43
@lgfa29 lgfa29 changed the title Update to Nomad 1.3.1 and add support to volume topologies. Update to Go 1.17, Nomad 1.3.1, and add support to volume topologies. Jun 8, 2022
@lgfa29 lgfa29 marked this pull request as ready for review June 8, 2022 16:31
@lgfa29 lgfa29 requested review from jrasell and tgross June 8, 2022 16:31
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lgfa29 lgfa29 merged commit 0af528b into main Jun 9, 2022
@lgfa29 lgfa29 deleted the f-volume-topologies branch June 9, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad volume missing topology_request
2 participants