Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy_override to job. #28

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Add policy_override to job. #28

merged 3 commits into from
Mar 23, 2018

Conversation

paddycarver
Copy link
Contributor

Add a policy_override field to nomad_job to override any
soft-mandatory Sentinel policies that may fail during the job
registration. Depends on #27.

The only files changed in this PR that aren't from #27 being its
base are the changes in nomad/resource_job.go,
nomad/resource_job_test.go, and website/docs/r/job.html.markdown.
The rest can be safely ignored/reviewed in #27 instead.

@paddycarver paddycarver requested a review from a team February 20, 2018 11:15
@paultyng
Copy link
Contributor

Could you possibly do an initial +external run as its own commit to shrink that first commit a little? Or is it all the same dependencies needed in that one?

@paddycarver
Copy link
Contributor Author

All the dependencies are needed to make #27 work. #27 is needed to make this work.

This shouldn't have any new dependencies of its own.

Add a `policy_override` field to `nomad_job` to override any
soft-mandatory Sentinel policies that may fail during the job
registration. Depends on #27.
Copy link

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddycarver paddycarver merged commit 1da750f into master Mar 23, 2018
@cgbaker cgbaker deleted the paddy_policy_override branch March 1, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants