F rich diff merged #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new CustomizeDiff mechanism, we can verify that the given jobspec is valid at plan time, and then include some information in the diff showing high-level changes that are implied by the jobspec changes. We can also use the JobModifyIndex mechanism to detect if changes are made outside of Terraform between our various operations, thus helping us keep our promise that Terraform will do what the plan says or produce an error.
ghost
added
cgbaker
force-pushed
the
f-rich-diff-merged
branch
from
27de12a
to
2532777
Compare
cgbaker
force-pushed
the
f-rich-diff-merged
branch
from
2532777
to
841f4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged #15, fixed a number of broken tests.
improved
make localtestaccadded
allocation_idsto Nomad Job resources