Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Nomad to 0.10.0 #77

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Add support for Nomad to 0.10.0 #77

merged 1 commit into from
Sep 25, 2019

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Sep 18, 2019

This PR updates the dependencies from Nomad to support the new features available on Nomad 0.10.0.

The mismatch between how Nomad and this provider manage dependencies (govendor vs Go modules) creates an overhead on how to access Nomad entities that are not available in the api module.

Closes #76.

@lgfa29
Copy link
Contributor Author

lgfa29 commented Sep 24, 2019

Files under vendor and nomad/core were copied as-is, so there's need to review them.

@lgfa29 lgfa29 marked this pull request as ready for review September 24, 2019 22:09
@lgfa29 lgfa29 requested a review from cgbaker September 24, 2019 22:09
cgbaker
cgbaker approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lgfa29 lgfa29 merged commit 4fc7a6b into master Sep 25, 2019
@lgfa29 lgfa29 deleted the nomad-010 branch September 25, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

Assignees
No one assigned
Labels
dependencies size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Nomad parser/API to 0.10
2 participants
@lgfa29 @cgbaker