Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Terraform SDK to the new Terraform Plugin SDK library #78

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Update Terraform SDK to the new Terraform Plugin SDK library #78

merged 1 commit into from
Sep 25, 2019

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Sep 25, 2019

Terraform Provider plugin SDK now lives in a separate project.

This PR migrates the Nomad provider using the provided migration tool:

$ tf-sdk-migrator check
$ tf-sdk-migrator migrate
$ go mod vendor

@lgfa29 lgfa29 added this to the 1.4.2 milestone Sep 25, 2019
@ghost ghost added the size/XXL label Sep 25, 2019
@lgfa29 lgfa29 requested a review from cgbaker September 25, 2019 19:19
cgbaker
cgbaker approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appilon
Copy link
Contributor

appilon commented Sep 25, 2019

No new failures in TC

@appilon appilon merged commit ad5551f into master Sep 25, 2019
@appilon appilon deleted the update-terraform-sdk branch September 25, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgfa29 @appilon @cgbaker