Resource "Create" should read from plan, not config?

[jaygorrell]

I could be mistaken on this, but the documentation and hashicups all recommend reading from the plan for create.

However, this scaffolding is configured to read from config:

terraform-provider-scaffolding-framework/internal/provider/example_resource.go

Line 58 in 194f73f

diags := req.Config.Get(ctx, &data)

edit: As an aside, I'm not super clear on when you would actually read directly from config outside of a data source.

[project0]

Hmm, i stumbled across this as well and i am actually unsure what is the difference. At least documentation is not clear here.
While testing a bit, it seems that Plan may contain unknown values. Config did seem to contain the final values.

This discussion seems related: hashicorp/terraform-plugin-framework#191 (comment)

Nevertheless, some clarification would be great.

[bflad]

Hi @jaygorrell 👋 Thank you for raising this.

Indeed, the general recommendation for the Create method is to access the plan instead of configuration. The following documentation and code should reflect this now:

https://www.terraform.io/plugin/framework/resources#create

https://github.com/hashicorp/terraform-provider-hashicups-pf/blob/12e9150e4df62eb6f86dd074936f2c6155865ce5/hashicups/order_resource.go#L143

terraform-provider-scaffolding-framework/internal/provider/example_resource.go

Line 86 in 0c93ae4

resp.Diagnostics.Append(req.Plan.Get(ctx, &data)...)

If there are other locations which reference req.Config during Create without any comment clarification, please reach out and we'll get those updated.