[WIP] r/policy_set: add support for VCS policy sets #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
vancluever
changed the title
|
Depends on hashicorp/go-tfe#77. |
vancluever
force-pushed
the
vcs-policy-set-support
branch
from
2648d59
to
caa666c
Compare
davidcelis
reviewed
Jun 14, 2019
davidcelis
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
This looks right to me 👍 will probably want @chrisarcand's review too once he's back!
svanharmelen
suggested changes
Jun 14, 2019
vancluever
force-pushed
the
vcs-policy-set-support
branch
2 times, most recently
from
07a60ea
to
7e6fc50
Compare
This adds the necessary changes to allow for VCS policy sets. VCS-backed policy sets are defined by supplying the vcs_repo - and optionally, policies_path, arguments to the tfe_policy_set resource. This is in lieu of policy_ids. Changing either vcs_repo or policies_path will result in a new resource being forced.
vancluever
force-pushed
the
vcs-policy-set-support
branch
from
7e6fc50
to
e1994da
Compare
|
I think the changes here should comprise most of the final changes necessary to put this through. @svanharmelen I'd still like to hear your thoughts/response of the ordering of the options. I'll defer to your judgement here. |
svanharmelen
approved these changes
Jun 19, 2019
|
@vancluever I made a few small changes to make sure all logic is consistent (mainly the tests). It would be great if you could review and run the tests one more time to make sure they all pass. If they do, this should be good to be merged and released 👍 |
|
Looks good, this all passes. I will be merging shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary changes to allow for VCS policy sets.
VCS-backed policy sets are defined by supplying the vcs_repo - and
optionally, policies_path, arguments to the tfe_policy_set resource.
This is in lieu of policy_ids.
Changing either vcs_repo or policies_path will result in a new
resource being forced.