Update certificate ready_for_renewal during refresh? #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in locally_signed_cert and self_signed_cert resources (#268)
bflad
reviewed
Oct 5, 2022
bflad
reviewed
Oct 5, 2022
Comment on lines
274
to
277
| res.Diagnostics.AddWarning( | ||
| "Certificate is ready for renewal at time of creation", | ||
| fmt.Sprintf("Early renewal hours (%d) is greater than or equal to validity period hours (%d)", newState.EarlyRenewalHours.Value, newState.ValidityPeriodHours.Value), | ||
| ) |
There was a problem hiding this comment.
Was there a specific ask for this warning diagnostic? Practitioners may be intentionally setting their configurations so certificates are recreated every run. Otherwise, we will need an opt-out mechanism, since there is nothing like that available in core.
There was a problem hiding this comment.
This was mentioned by @apparentlymart in slack.
There was a problem hiding this comment.
Created a followup issue for this, since we should consider whether it should happen now, in the future, or differently by enforcing >= 1 instead of 0: #282 👍
There was a problem hiding this comment.
Thanks for creating the follow-up issue. I've removed the warning diagnostics for now.
bflad
approved these changes
Oct 11, 2022
bflad
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #268
Requires Adding RefreshState test step to be merged, tagged and released so that tests verifyingterraform refreshbehaviour in isolation can run. Build will fail until theRefreshStatetest step is available.