Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Change: Multiple NICs on HyperV provider #8849

Open
wiltaylor opened this issue Aug 4, 2017 · 8 comments
Open

Proposed Change: Multiple NICs on HyperV provider #8849

wiltaylor opened this issue Aug 4, 2017 · 8 comments

Comments

@wiltaylor
Copy link

wiltaylor commented Aug 4, 2017

Vagrant version

Vagrant 1.9.7

Host operating system

Windwos 10 Creative Update

Guest operating system

Any

Expected behavior

When defining multiple networks in a vagrant file it should result in multiple network cards being attached to the resultant virtual machine.

Actual behavior

The latest network entry becomes the network card added to the virtual machine.

Proposed Changes:

I am thinking of doing the following:

  • Move networking out to a new action.
  • New network action will clear existing network interfaces
  • New network action will then create a NIC for each network in config like other providers.
  • Treat the first network like the previous single network (i.e. mac config or which interface to get ip address from). Mainly done to preserve backwards compatibility
  • Add mac to property to network to set mac addresses per interface.

Out of scope: - Will probably add these later. Need to get some of the basics working first though.

  • Ability to assign static ip addresses
  • port forwarding
@wiltaylor
Copy link
Author

@mwrock do you have any thoughts on this?

@mwrock
Copy link
Contributor

mwrock commented Aug 5, 2017

I'd agree that specifying multiple network configs should result in multiple NICs. I'm not sure if this is a Hyper-V provider issue or accross all providers on windows guests. I wonder what happens on vbox for instance.

@wiltaylor
Copy link
Author

Nah it looks like its just hyper v, basically the import action only takes the name of one vswitch, so whatever config was last in the config becomes that vswitch.

Instead I have now created an action that wipes out all the network adapters on a vm and then adds them back again for each switch in config.

I will try and post the PR in the next few days.

@gurry
Copy link

gurry commented Jan 26, 2018

@wiltaylor Any update on this?

@Jaskaranbir
Copy link

Can we please get this moving forward? There's also #9439, but it too requires @wiltaylor's signature on CLA, and it seems he hasn't been as active on GitHub recently. I am willing to give this a try, but definitely one of the must-have features IMO.

@briancain briancain added this to the 2.3 milestone May 19, 2020
@elico
Copy link

elico commented Oct 29, 2020

@briancain @Jaskaranbir Was there any change with this?
I am working on a lab on Hyper-V and it would really help to be able to use multiple NICs.

@chrisroberts chrisroberts removed this from the 2.3 milestone Jul 27, 2022
@ShaunLawrie
Copy link

I commented on the static IP issue but it's somewhat relevant to this as well #8384 (comment)

@rauldoliveira
Copy link

This a very interesting feature, are there updates in this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

9 participants