Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring not working with //go:embed web_ui/* #12507

Closed
heppu opened this issue Sep 8, 2021 · 2 comments
Closed

Vendoring not working with //go:embed web_ui/* #12507

heppu opened this issue Sep 8, 2021 · 2 comments

Comments

@heppu
Copy link
Contributor

heppu commented Sep 8, 2021

I tried to use main branch of vault as dependecy since it has the fix which is needed for Go 1.17 and that's when I found a new problem. When running go mod vendor Go will now try to copy also all files described with //go:embed directive. Since those files are not part of the vaults git repo vault cannot be vendored.

To Reproduce

$ go get -d github.com/hashicorp/vault@main
go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead.
$ go mod vendor
go mod vendor: pattern web_ui/*: no matching files found

Expected behavior
Running go mod vendor should work with vault as dependecy.

Environment:
go1.17 linux/amd64
github.com/hashicorp/vault@main

@hsimon-hashicorp
Copy link
Contributor

As this is not a HashiCorp-supported method of using Vault, I will close this issue. If you would like to submit a PR to address this, we'd be happy to review it, but at this time, we will not be making these changes. Thanks for understanding.

@heppu
Copy link
Contributor Author

heppu commented Sep 9, 2021

@hsimon-hashicorp I have now created the PR so should we reopen this issue or should I create a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants