Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Content-Type negotiation #7936

Closed
fischerman opened this issue Nov 26, 2019 · 0 comments · Fixed by #7958
Closed

Prometheus Content-Type negotiation #7936

fischerman opened this issue Nov 26, 2019 · 0 comments · Fixed by #7958

Comments

@fischerman
Copy link

Is your feature request related to a problem? Please describe.
Scraping Prometheus metrics requires the query parameter ?format=prometheus. In a Kubernetes setup, scraping endpoints tend be discovered using pod annotations (e.g. prometheus.io/path), however an annotation for parameters is not very common (? is escaped properly by Prometheus, so parameters cannot be provided in the path).

Describe the solution you'd like
Prometheus does Content-Type negotiation (see here). When Vault sees the schema schema="prometheus/telemetry" it could serve Prometheus metrics without having to specify the format parameter.

Describe alternatives you've considered
None

Explain any additional use-cases
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants