Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Comment broken on tfvars files #936

Closed
1 of 2 tasks
NachoxMacho opened this issue Feb 11, 2022 · 2 comments · Fixed by #937
Closed
1 of 2 tasks

Toggle Comment broken on tfvars files #936

NachoxMacho opened this issue Feb 11, 2022 · 2 comments · Fixed by #937
Labels
bug Something isn't working syntax

Comments

@NachoxMacho
Copy link
Contributor

Versions

This bug is reproducible in:

  • the latest version of the extension (below)
  • the latest version of the language server (below)

Extension

v2.19.0

Language Server

terraform-ls 0.25.2

VS Code

Version: 1.64.2
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09R22:02:28.252Z (1 day ago)
Electron: 13.5.2
Chromium: 91.0.4482.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19044

Operating System

Windows 10

Terraform Version

Not installed

Steps To Reproduce

  1. Open blank VSCode window
  2. Verify HashiCorp Terraform is only extension installed and enabled
  3. Create new blank file
  4. Select Language as terraform-vars
  5. Add example code
    thing = {
        
    }
  6. Click any line and press shortcut to toggle line comment

Expected Behavior

Line should add a # to the front

Actual Behavior

Nothing happens

Additional context

I've also noticed that bracket colorization doesn't take effect when running through these steps:
image

When it should look like:
image

@jpogran
Copy link
Contributor

jpogran commented Feb 11, 2022

Nice work!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants