Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Default the platform on upgrade to the one in the context #1461

Merged
merged 4 commits into from May 12, 2021

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented May 12, 2021

Fixes #1233

@evanphx evanphx requested review from briancain and a team May 12, 2021 00:12
@github-actions github-actions bot added the core label May 12, 2021
Copy link
Contributor

@izaaklauer izaaklauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in a comment, but otherwise works for me locally and looks good!

internal/cli/server_upgrade.go Outdated Show resolved Hide resolved
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Works as expected in my testing 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use platform defined on Server for Upgrade/Uninstall commands if no -platform flag is provided
3 participants