This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Upgrade docker/docker #1685
Merged
Upgrade docker/docker #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1684. It's a bit of a mystery to me why running `go get github.com/docker/docker; go mod tidy` resulted in this big of a dependency chain, including a bbolt upgrade.
mitchellh
reviewed
Jun 22, 2021
krantzinator
approved these changes
Jun 22, 2021
|
I think the previous upgrade of docker introduce the issue, and then this upgrade fixes it. Any idea which change fixes it? |
This is what fixes it: moby/moby#41667 I actually found and made that fix myself locally, and then was disappointed when I rushed to make the docker PR and realized we were behind and someone had beaten me to it. |
This was referenced Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1684.
It's a bit of a mystery to me why running
go get github.com/docker/docker; go mod tidyresulted in this many dependency changes, including a bbolt upgrade.