This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Waypoint server: Support insecure HTTP listener #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krantzinator
approved these changes
Sep 27, 2021
mitchellh
force-pushed
the
feature/insecure-http
branch
from
c407788
to
44eb13a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
-listen-http-insecureflag to the Waypoint server to create an insecure (non-TLS) HTTP listener.This insecure HTTP listener behaves in two ways:
X-Forwarded-Protoofhttps, it routes the traffic.The insecure HTTP listener is primarily to help with the Kubernetes use case where resources such as
Ingressdo not typically talk to their backends with TLS. Further, it helps the basicLoadBalancer Servicecase because port 80 will redirect to TLS versus not connecting today.This is opt-in functionality. If the flag isn't specified, an insecure listener is not created.
There is no way to get this today with
waypoint install(unless you specify a manual flag). The plan is to integrate this into the Waypoint Helm chart directly.