cli: Project ops part 1 - CLI updates #2413
Conversation
krantzinator
added
the
pr/no-changelog
krantzinator
removed
the
pr/no-changelog
|
Pause: there is some weirdness with |
krantzinator
changed the title
krantzinator
changed the title
krantzinator
force-pushed
the
feat/project-ops
branch
from
ca40dc9
to
ff5982c
Compare
internal/cli/deployment_list.go
Outdated
| @@ -71,6 +71,7 @@ func (c *DeploymentListCommand) Run(args []string) int { | |||
| client := c.project.Client() | |||
|
|
|||
| err := c.DoApp(c.Ctx, func(ctx context.Context, app *clientpkg.App) error { | |||
| app.UI.Output("%s", app.Ref().Application, terminal.WithHeaderStyle()) | |||
There was a problem hiding this comment.
Same as other about the output not being valid json in this case.
There was a problem hiding this comment.
I'm also thinking for the json case, for all projects, instead of returning two separate json structures separated by newlines, we should probably collect and wrap them into a single array for each item listed? Maybe that's a future enhancement 馃
There was a problem hiding this comment.
And if we did that, does it mean single apps are still an item in an array too?
There was a problem hiding this comment.
Hm, we could do that by storing the json on the command, returning nothing in the DoApp if flag.json, and then returning the collected json outside of that loop?
There was a problem hiding this comment.
Sure, we could make a more generic mechanism for displaying json where you give the CLI a struct that it will json-ify (and thusly supports multiple structs)
internal/cli/deployment_list.go
Outdated
| @@ -71,6 +71,7 @@ func (c *DeploymentListCommand) Run(args []string) int { | |||
| client := c.project.Client() | |||
|
|
|||
| err := c.DoApp(c.Ctx, func(ctx context.Context, app *clientpkg.App) error { | |||
| app.UI.Output("%s", app.Ref().Application, terminal.WithHeaderStyle()) | |||
There was a problem hiding this comment.
I'm also thinking for the json case, for all projects, instead of returning two separate json structures separated by newlines, we should probably collect and wrap them into a single array for each item listed? Maybe that's a future enhancement 馃
krantzinator
force-pushed
the
feat/project-ops
branch
from
002e6b6
to
87a0295
Compare
(Most of the
Files changedare updates to all the CLI docs page because of the new-projectflag 馃槄 )This is a cli-only PR adding a
ProjectTargetRequiredconfig item and correspondingWithMultipleAppoption to set some commands to target all applications with the targeted project by default. Users can still specify-app=APPNAMEto target a specific app.This change also removes the
-projectflag from thecontext [...]commands and makes it a global flag. Various other documentation updates are included here as well to amend some of our language from being app-specific to project-specific.This is a surface layer change, as it only supports functionality that we already had on the CLI side, and does not add any project-scoped awareness to our server or job system. It seemed like a good first pass to start with to get the CLI-messaging right.
With this functionality, all commands updated with the new config option will now run that command against each application in the project in sequence. A failure in one app is non-blocking; all applications will finish their jobs individually.
Notable: I moved the
DoAppininternal/cli/deployment_destroy.gofrom the private func it was in (getDeployments) up to the parentRunfunction; this matches all the other CLI commands and sets us up better to move some of this project-scope to operations later.Example output:
