waypoint install fails with runner install due to missing args

[arbourd]

Describe the bug

Waypoint install does not successfully install runner, with using Nomad and a host volume.

The cause is most likely related to arguments not being properly set to the runner install process that follows.

Steps to Reproduce

$ waypoint install -accept-tos -plain -platform=nomad -nomad-host-volume=scratch
-> Initializing Nomad client...
-> Checking for existing Waypoint server...
-> Detected existing Waypoint server
-> Connecting to: 147.28.148.193:9701
-> Attempting to make connection to server...
-> Successfully connected to Waypoint server in Nomad!
-> Retrieving initial auth token...
-> Configuring server...
-> Server installed and configured!
->
-> Retrieving new auth token for runner...
-> Installing runner...
-> Initializing Nomad client...
! Error installing the runner: please include '-nomad-csi-volume-provider' or '-nomad-host-volume'

  The Waypoint runner failed to install. This error occurred after the
  Waypoint server was successfully installed. Your CLI is configured to
  use the installed server. If you want to retry, you must uninstall the
  server first.

Expected behavior

The server and runner to be installed.

Waypoint Platform Versions

• Waypoint CLI Version: v0.9.0 (2a7b890)
• Waypoint Server Platform and Version: nomad, v0.9.0

Additional context

Add any other context about the problem here.

[paladin-devops]

@arbourd thanks for opening this issue! The result of your install command is the expected result; however the output is inaccurate with regard to why it failed. The runner install changes made in v0.9.0 include a persistence requirement for the runner. The runner that is installed alongside the server with the install command therefore requires an additional flag, -nomad-runner-host-volume. However the output message on the CLI is incorrectly indicating that you should provide a flag which you already have, -nomad-host-volume.

Thanks for pointing this out, we will address this! In the meantime, if you add an additional host volume for a Waypoint runner and specify that flag on the install command, I think that would help you get past the install failure!

[kjaleshire]

@paladin-devops is it possible for the runner to use CSI-backed storage?

[paladin-devops]

@kjaleshire yes it is! There is a series of flags for configuring persistence with CSI:

  -nomad-runner-csi-volume=<string>
      The name of the volume to initialize for the Waypoint runner within the
      CSI provider.

  -nomad-runner-csi-volume-capacity-max=<int>
      Waypoint runner Nomad CSI volume capacity maximum, in bytes. The default
      is 2147483648.

  -nomad-runner-csi-volume-capacity-min=<int>
      Waypoint runner Nomad CSI volume capacity minimum, in bytes. The default
      is 1073741824.

  -nomad-runner-csi-volume-provider=<string>
      Name of the CSI volume provider to use for the Waypoint runner.