Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Update all error returns in RunnerJobStream to use hcerr.Externalize() #3872

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Update all error returns in RunnerJobStream to use hcerr.Externalize() #3872

merged 4 commits into from
Sep 15, 2022

Conversation

catsby
Copy link
Member

@catsby catsby commented Sep 14, 2022

Wrap error returns in hcerr.Externalize() to log more details correctly

@catsby catsby requested review from a team, evanphx and izaaklauer September 14, 2022 16:14
@catsby catsby marked this pull request as ready for review September 14, 2022 16:14
@catsby catsby added core pr/no-changelog No automatic changelog entry required for this pull request labels Sep 14, 2022
@github-actions github-actions bot removed the core label Sep 14, 2022
izaaklauer
izaaklauer approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@izaaklauer izaaklauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@catsby catsby merged commit e9e1ad7 into main Sep 15, 2022
@catsby catsby deleted the externalize-runnerstream-errs branch September 15, 2022 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@izaaklauer izaaklauer izaaklauer approved these changes

@evanphx evanphx Awaiting requested review from evanphx

Assignees
No one assigned
Labels
core/server externalize pr/no-changelog No automatic changelog entry required for this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@catsby @izaaklauer