This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
WatchTask and StopTask for AWS ECS Task Launcher
#3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaaklauer
reviewed
Sep 28, 2022
briancain
reviewed
Sep 28, 2022
Implement ECS StopTask, to kill ODR if StopTask needs to. Simplified concurrency of WatchTask for ECS. Status is being sent over a string channel and used in the main goroutine.
… WatchTask out of select block.
paladin-devops
force-pushed
the
f-ecs-watch-task
branch
from
59d9199
to
ab34e72
Compare
Reporting the ODR task status repeatedly in the loop makes for noisy logs even at the debug level.
briancain
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3713.
The task launcher plugin for AWS ECS will use the ECS and CloudWatch AWS APIs to get the logs of the running on-demand runner task in ECS.