This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ui: make <ResourceTable> resilient to resources without IDs
#3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwhite
force-pushed
the
ui/resource-table-missing-id
branch
from
d1399b7
to
4176d53
Compare
gregone
approved these changes
Sep 23, 2022
Addresses #3928 Co-authored-by: Shirley Xiaolin Xu <xiaolin@hashicorp.com>
jgwhite
force-pushed
the
ui/resource-table-missing-id
branch
from
4176d53
to
8ec1c9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the change?
See #3928 for some background. In short, this stops the app from crashing hard when it encounters a resource without an ID.
What does it look like?
Before
After
How do I test it?
cd ui && yarn start local