This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
server: Ensure RunPipeline api returns correct order for AllJobIds for pipelines with embedded pipeline graphs
#3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the pipeline name and step name that was already visisted.
This test verifies that when running a pipeline, it returns the job ids in the expected order for which a pipeline will run each step. Embedded pipeline test is next
This commit adds a unit test that reliably repros the issue: #3869 It has two pipeline step refs back to back.
Prior to this commit, if you built a pipeline that had two neighboring pipeline step refs, i.e. two adjacent pipeline graphs, the graph builder would not correctly draw the relationship between steps and the graphs child steps, resulting in job stream ids to be read out of order when a RunPipeline was called. This commit fixes that by drawing the edge flow properly, as well as handling the parent steps dependencies while traveling through each pipeline ref graph.
briancain
added
pr/no-changelog
briancain
removed
the
pr/no-changelog
briancain
changed the title
RunPipeline api returns correct order for AllJobIds for pipelines with embedded pipeline graphs
briancain
added
bug
evanphx
approved these changes
Sep 29, 2022
paladin-devops
approved these changes
Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where the
RunPipelineAPI was returning the wrong order ofAllJobIdsbased on how it constructed and sorted the full pipeline graph. This resulted in the jobstream client reading pipeline jobs out of order from the actual execution order that the jobs ran in. It also adds additional unit tests that check the expected order of job ids to steps.Fixes #3869