This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Correctly set image pull policy during k8s install #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver and runner installations.
briancain
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Looks good to me!
brian@ubuntu:waypoint-tetris λ waypoint install -accept-tos -platform=kubernetes -k8s-server-image="localhost:5000/waypoint:dev" -k8s-pull-policy="Always" ±[main]
⚠️ Kind cluster detected!
Installing Waypoint to a Kind cluster requires that the cluster has
LoadBalancer capabilities (such as metallb). If Kind isn't configured
in this way, then the install may hang. If this happens, please delete
all the Waypoint resources and try again.
✓ Service "waypoint" is ready
✓ Server bootstrap complete!
✓ Waypoint server installed with Helm!
...
...
...
brian@ubuntu:waypoint-tetris λ kubectl get pod/waypoint-server-0 -o yaml | grep -i pullPolicy ±[main]
imagePullPolicy: Always
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After converting to Helm for the server installation, as well as adding
runner install, the configuration for k8s for the image pull policy was not updated to be set for a Helm install. This PR fixes that and closes #3866.