This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
nomad-jobspec plugin periodic and system job fixes
#3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
added
plugin/nomad-jobspec
ecosystem
Nomad periodic jobs don't have an "update" stanza, so we no longer check for canaries for such jobs. We also do not monitor a Nomad evaluation after the job is registered, because not all jobs (namely, periodic jobs) have an evaluation immediately after job registration.
paladin-devops
force-pushed
the
b-nomad-jobspec-periodic-jobs
branch
from
40990de
to
97d4850
Compare
System jobs don't use canaries, and thusly we don't check for canaries if the job being deployed is a system job.
paladin-devops
changed the title
nomad-jobspec plugin periodic job supportnomad-jobspec plugin periodic and system job fixes
briancain
approved these changes
Oct 3, 2022
demophoon
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad periodic jobs don't have an "update" stanza, so we no longer check for canaries for such jobs. We also do not monitor a Nomad evaluation after the job is registered, because not all jobs (namely, periodic jobs) have an evaluation immediately after job registration. These changes allow periodic jobs to be registered using the jobspec plugin!
Additionally, we don't check for canaries if the job is of type
system, becausesystemjobs don't support canaries at this time.Closes #2982.
Closes #3920.