ui: removed fix for resolved safari bug with xterm/webgl #4054

sabrinako · 2022-10-14T20:02:57Z

During HCP Waypoint beta testing, we were informed of a bug with viewing logs on Safari. The issue ended up being we had this if condition to handle a bug that previously existed with xterm rendering with Safari/WebGL which has since been fixed.
Bug has been fixed in HCP Waypoint but not OSS yet until this PR

amyrlam · 2022-10-14T21:56:02Z

Deletion looks good 👍. Question: should it be a bug fix in the changelog?

jgwhite · 2022-10-17T10:24:17Z

Question: should it be a bug fix in the changelog?

Yup, this is a user-facing bugfix so no reason not to.

sabrinako · 2022-10-17T18:10:26Z

@amyrlam sounds good! I just updated the branch and added the changelog

amyrlam

looks good!

Not sure if the go-tests failure is just flaky.

sabrinako added the ui label Oct 14, 2022

sabrinako self-assigned this Oct 14, 2022

sabrinako force-pushed the xterm-fix branch from 45adefd to 55c04f8 Compare October 14, 2022 20:19

vercel bot deployed to Preview – waypoint-ui October 14, 2022 20:21 View deployment

sabrinako marked this pull request as ready for review October 14, 2022 20:26

sabrinako requested a review from a team October 14, 2022 20:26

ui: removed fix for resolved safari bug with xterm/webgl

2506f66

sabrinako force-pushed the xterm-fix branch from 55c04f8 to 2506f66 Compare October 17, 2022 18:09

vercel bot deployed to Preview – waypoint-ui October 17, 2022 18:11 View deployment

amyrlam approved these changes Oct 17, 2022

View reviewed changes

sabrinako merged commit 4da8370 into main Oct 17, 2022

sabrinako deleted the xterm-fix branch October 17, 2022 19:21

Provide feedback