This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/config: Fix panic if no scoped use stanza found #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if you attempted to use a build, deploy, or release stanza that had a workspace scoped 'use' stanza but you were not using that workspace, Waypoint would panic attempting to evaluate the Use plugin type. This commit fixes that by first looking to see if a Use stanza is defined at all prior to obtaining the Use type. Fixes #3759
briancain
added
bug
briancain
removed
the
pr/no-changelog
|
Actually - I think it makes sense to simply return nothing in the same way we do for no |
This is to continue to support plugins with no Releaser defined.
briancain
changed the title
evanphx
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if you attempted to use a build, deploy, or release stanza that had a workspace scoped 'use' stanza but you were not using that workspace, Waypoint would panic attempting to evaluate the Use plugin type. This commit fixes that by first looking to see if a Use stanza is defined at all prior to obtaining the Use type.
Fixes #3759