This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
cli: Only show CompleteTime if set #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `waypoint pipeline list` CLI would attempt to show an invalid complete time, even if not set on the job. This would mean if you started a pipeline, the list CLI would claim that the pipeline completed "a long time ago", which is really code for that timestamp being nil. This commit fixes that behavior by only setting the complete time string if set on the job. Fixes #3748
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
evanphx
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
waypoint pipeline listCLI would attempt to show an invalid complete time, even if not set on the job. This would mean if you started a pipeline, the list CLI would claim that the pipeline completed "a long time ago", which is really code for that timestamp being nil. This commit fixes that behavior by only setting the complete time string if set on the job.Fixes #3748