This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Feature: Update pipelines parser to evaluate input variables #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the pipeline parsing for steps to store step values in the Step struct rather than the hclStep raw struct. This is intended to support lazy loading for when Waypoint resolves input variables later on during config parsing.
Prior to this commit, the init CLI would upsert the full protobuf structure of a pipeline. This was fine before input variables, but now given how Waypoint internally lazy-evaluates input variables later, this approach no logner works. This commit updates the init cli to instead behave more like how the init CLI handles syncing Applications: The smallest structure possible i.e. a name, owner, and a root step. This data gets re-upserted on configsync and before running a pipeline, so this init simply upserts a basic structure on initialiation.
briancain
added
the
pr/no-changelog
|
A note to the reviewer: It doesn't seem like |
briancain
removed
the
pr/no-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces input variables being evaluated inside
pipeline {}stanzas. It ends up rearranging how we parse pipelines and steps to support the lazy-decoding that Waypoint does to evaluate and resolve variables later in the parsing process.It also had to modify how
waypoint initdoes its initial sync of pipeline definitions. Now instead we do a "shallow sync" of the pipeline name, owner, and a base step. This mirrors how we sync applications onwaypoint initin that we don't sync the entire parsed hcl config, only the app name on init.Fixes #4122