Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

nomad install with csi persistent storage not respecting nomad-csi-parameters #4152

Closed
margiran opened this issue Nov 2, 2022 · 1 comment · Fixed by #4157
Closed

nomad install with csi persistent storage not respecting nomad-csi-parameters #4152

margiran opened this issue Nov 2, 2022 · 1 comment · Fixed by #4157

Comments

@margiran
Copy link

margiran commented Nov 2, 2022

Describe the bug
waypoint does not pass the csi parameters to the plugin

$ waypoint version
CLI: v0.10.2

$ waypoint install \
-platform="nomad" \
-accept-tos \
-nomad-consul-service=true \
-nomad-host="http://127.0.0.1:4646" \
-nomad-csi-volume-provider=nomad \
-nomad-csi-plugin-id=aws-efs0 \
-nomad-csi-parameters="provisioningMode=efs-ap" \
-nomad-csi-parameters="fileSystemId=fs-***********" \
-nomad-csi-parameters="directoryPerms=700"
Creating persistent volume
! Error installing server into nomad: Failed creating Nomad
persistent volume: Unexpected response code: 500 (1 error
  occurred:
        * controller create volume: CSI.ControllerCreateVolume:
volume
  "waypoint-server" snapshot source &{"" ""} is not compatible
with these
  parameters: rpc error: code = InvalidArgument desc = Missing
provisioningMode
  parameter
  
  )

Steps to Reproduce

  • create an efs file system in aws
  • create and run controller and node jobs in nomad
  • running the command above

Expected behavior
waypoint should be able to create volume

Additional context
in this commit, CsiParams added (a8775ba)

Moving common nomad function to installutils but csiParams Has been removed in this refactoring (59c0648)

CsiParams is missing in this function call (https://github.com/hashicorp/waypoint/blob/main/internal/serverinstall/nomad.go#L216-L229)

@evanphx
Copy link
Contributor

evanphx commented Nov 2, 2022

@margiran This should be fixed in the next release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants