This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Update bootstrap runner profile OCI URL during upgrade #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the server upgrade command would use the installRunner function to install a new runner during the upgrade with the new version, AND update the runner profile to use the config defined in server_upgrade.go. However, the update of the runner profile never happened, because existingODRConfigSetup was set to true, skipping the code which would update the profile.
paladin-devops
force-pushed
the
b-upgrade-runner-profile-oci-url
branch
from
630c329
to
e9cba71
Compare
izaaklauer
approved these changes
Nov 3, 2022
|
Tested with Nomad as well: // install with 0.10.2 CLI
% waypoint install -platform=nomad -nomad-host-volume=waypoint -nomad-runner-host-volume=waypoint-runner -nomad-service-provider=nomad -accept-tos
// success
% waypoint runner profile list
Runner profiles
NAME | PLUGIN TYPE | OCI URL | TARGET RUNNER | DEFAULT
--------------------------+-------------+-------------------------------+---------------+----------
nomad-bootstrap-profile | nomad | hashicorp/waypoint-odr:latest | * | yes
// upgrade w/this branch
% ./waypoint server upgrade -platform=nomad -nomad-host-volume=waypoint -nomad-runner-host-volume=waypoint-runner -nomad-service-provider=nomad -nomad-server-image=hashicorp/waypoint:0.10.2 -nomad-odr-image=hashicorp/waypoint-odr:0.10.2 -auto-approve
// success
% waypoint runner profile list
Runner profiles
NAME | PLUGIN TYPE | OCI URL | TARGET RUNNER | DEFAULT
--------------------------+-------------+-------------------------------+---------------+----------
nomad-bootstrap-profile | nomad | hashicorp/waypoint-odr:0.10.2 | * | yes |
catsby
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the various -odr-image flags for each platform on server upgrade were being ignored, so you'd end up with this:
% waypoint server upgrade -platform=docker -docker-server-image=waypoint:dev -docker-odr-image=waypoint-odr:dev // successful upgrade % waypoint runner profile list Runner profiles NAME | PLUGIN TYPE | OCI URL | TARGET RUNNER | DEFAULT ---------------------------+-------------+-------------------------------+---------------+---------- docker-bootstrap-profile | docker | hashicorp/waypoint-odr:latest | * | yes // the OCI URL did not changeAfter this PR:
% waypoint server upgrade -platform=docker -docker-server-image=waypoint:dev -docker-odr-image=waypoint-odr:dev // successful upgrade % waypoint runner profile list Runner profiles NAME | PLUGIN TYPE | OCI URL | TARGET RUNNER | DEFAULT ---------------------------+-------------+------------------+---------------+---------- docker-bootstrap-profile | docker | waypoint-odr:dev | * | yes