This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix pipeline exec steps run in Nomad
#4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
added
plugin/nomad
core/pipeline
Prior to this commit, the Nomad task launcher plugin previously set the "command" field for launching tasks. Before pipelines, this was fine for ODRs. However, pipelines pass a slice of string to the TaskLaunchInfo struct for the Entrypoint field. The Nomad Docker driver's command field accepts only string, not slice of string. Therefore, any exec steps for pipelines run by Nomad ODRs would fail to start. The entrypoint field of the Nomad Docker driver config does accept a slice of string.
paladin-devops
force-pushed
the
b-nomad-task-launcher-entrypoint
branch
from
8666ec2
to
6cad64c
Compare
briancain
reviewed
Nov 11, 2022
| "command": tli.Entrypoint, | ||
| "image": tli.OciUrl, | ||
| "args": tli.Arguments, | ||
| "entrypoint": tli.Entrypoint, |
There was a problem hiding this comment.
Interesting, surprised we didn't catch this with other ODR jobs! Do we not need to also set the command for the launched resource too?
There was a problem hiding this comment.
Nope! Setting the command in addition to the entrypoint here would just add args to the command that the entrypoint runs.
briancain
approved these changes
Nov 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the Nomad task launcher plugin previously set the "command" field for launching tasks. Before pipelines, this was fine for ODRs. However, pipelines pass a slice of string to the
TaskLaunchInfostruct (from the Waypoint plugin SDK) for the Entrypoint field. The Nomad Docker driver's command field accepts only string, not slice of string. Therefore, any exec steps for pipelines run by Nomad ODRs would fail to start before this PR.The entrypoint field of the Nomad Docker driver config does accept a slice of string, and that is the config now being set in the Nomad task launcher plugin.