This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Modify project destroy to require -p flag and delete projects created in UI without data source
#4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
reviewed
Nov 18, 2022
internal/cli/project_destroy.go
Outdated
| if c.project == nil { | ||
| c.ui.Output("The -project flag must be set.", terminal.WithErrorStyle()) | ||
| if c.flagProject == "" { | ||
| c.ui.Output("Must explicitly set -project (-p) flag to destroy project.", terminal.WithErrorStyle()) |
There was a problem hiding this comment.
I'd reprint the help text here with c.Flags().Help().
Suggested change
| c.ui.Output("Must explicitly set -project (-p) flag to destroy project.", terminal.WithErrorStyle()) | |
| c.ui.Output("Must explicitly set -project (-p) flag to destroy project.\n%s", c.Flags().Help(), terminal.WithErrorStyle()) |
Something like that.
Then we should update the usage string to explicitly show that the flag is now required:
Usage waypoint project destroy -project=<project-name> [options]
...
...
| _, err = c.project.DestroyProject(c.Ctx, &pb.Job_DestroyProjectOp{ | ||
| Project: &pb.Ref_Project{Project: project.Project.Name}, | ||
| SkipDestroyResources: c.skipDestroyResources, | ||
| }) |
There was a problem hiding this comment.
This confused me at first - I wasn't sure what the difference was between these two DestroyProject funcs. Maybe a quick doc comment note about how one is a client func that queues a DestroyProject operation, and the other is an API call to the server that deletes the projects record from the db with no job?
xiaolin-ninja
added
backport/0.10.x
backport/website
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests. :)
Previously,
waypoint project destroywould ignore whatever arguments provided and attempt to destroy project in current directory. This enforces the use of the-projector-pflag regardless of where the command is called to resolve this bug, and for extra guardrails.This PR also introduces the ability to delete projects created in the UI without a data source or
waypoint.hcl.